fix raw tag parsing to include multi-line html#101
fix raw tag parsing to include multi-line html#101SampsonCrowley wants to merge 1 commit intofoundation:masterfrom
Conversation
87a1ddc to
f43db16
Compare
|
Cool. Last thing: wouldn't it be best (and simpler) to put those tests as new cases? I imagine that the output from the gem and the original js package were different for these and they simply should match. |
|
@marcandre I'm not sure I follow, can you explain what you mean? As far as I remember (sorry not at my machine rn) I just added additional tests in the existing section that is testing this feature, to cover the expanded capability |
|
The |
|
FWIW, I think the specs you edited predate the |
|
Sounds like I need to rebase and edit a lil bit |
|
@marcandre so the main repo (I'm assuming at least) is also only parsing raw tags line-by line. does that mean I need to fix it there before proper multi-line HTML parsing will be allowed here for raw tags? also after rebasing, it looks like the original |
|
I will be fixing the multi-line issue in the main repo, so this fix can be properly moved to the cases spec without failing tests |
76df26b to
3a99db2
Compare
3a99db2 to
da18b91
Compare
fixes raw tag parsing mentioned in #95
since this is an HTML based library, and raw tags are supported in the repo, only allowing single line parsing is a huge surprise. this fixes that surprise