This repository was archived by the owner on Sep 8, 2025. It is now read-only.
chore: use helper functions to init test data and rm test instability#98
Draft
realaravinth wants to merge 5 commits intoforgeflux-org:masterfrom
Draft
chore: use helper functions to init test data and rm test instability#98realaravinth wants to merge 5 commits intoforgeflux-org:masterfrom
realaravinth wants to merge 5 commits intoforgeflux-org:masterfrom
Conversation
SUMMARY
DBIssue and DBComment loaded data from database when performing
updates via self.__update() which in some cases where unnecessary as a
fetch would have been performed just before invoking __update().
This patch introduces an optical parameter to provide recently
loaded data from DB
TEST INSTABILITY
db/test_comments test was unstable because data generated were saved
at separate locations, resulting in uncontrolled/weird data created
and updated time. All test data are now saved with one save call,
at the top most data type(DBComment is at a higher level as it wraps
over/dependant on DBIssue)
Member
Author
|
Apologies, I forgot to check in caching code which is WIP. Will update tomorrow. |
This was referenced Apr 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TEST INSTABILITY
db/test_comments test was unstable because data generated were saved at separate locations, resulting in uncontrolled/weird data created and updated time. All test data are now saved with one save call, at the top most data type(DBComment is at a higher level as it wraps over/dependent on DBIssue)