fix: allow 404 status code in OPTIONS request for WebDAV auth#56
Open
max-kroell wants to merge 1 commit intoflymzero:mainfrom
Open
fix: allow 404 status code in OPTIONS request for WebDAV auth#56max-kroell wants to merge 1 commit intoflymzero:mainfrom
max-kroell wants to merge 1 commit intoflymzero:mainfrom
Conversation
Some WebDAV servers return a 404 status for the OPTIONS request if the endpoint is not explicitly configured, even though authentication may still be valid. Previously, the implementation only allowed a 200 response and threw an error otherwise. This fix updates the authentication check to also accept 404, preventing unnecessary authentication failures and improving compatibility with a wider range of WebDAV servers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the authentication check in the
wdOptionsrequest for WebDAV servers. Previously, the implementation only allowed a200 OKresponse, throwing an error otherwise. However, some WebDAV servers may return404 Not Foundif the OPTIONS endpoint is not explicitly configured, even though authentication might still be valid.Changes Made:
404as a valid response instead of failing immediately.Why This is Needed:
OPTIONSfor authentication but still allow valid operations.404response.Logs of the Requests:
Details