Skip to content

Conversation

@JiGuoDing
Copy link
Collaborator

Ⅰ. Describe what this PR does

This PR tries to replace "read-all" with specific permissions for security reasons.

Ⅱ. Does this pull request fix one issue?

fixes #5398

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

…in .github/workflows/sonarcloud.yaml

Signed-off-by: JiGuoDing <485204300@qq.com>
Copilot AI review requested due to automatic review settings December 30, 2025 16:56
@gemini-code-assist
Copy link
Contributor

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@sonarqubecloud
Copy link

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances security by replacing the overly permissive read-all permission with specific contents: read permission at the workflow level in the sonarcloud.yaml GitHub Actions workflow file. This follows the principle of least privilege while maintaining functionality, as the job-level permissions already explicitly define all required access rights.

Key Changes:

  • Replaced permissions: read-all with explicit permissions: contents: read at the workflow level

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Dec 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.52%. Comparing base (63457dc) to head (7c3c0aa).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5399   +/-   ##
=======================================
  Coverage   57.52%   57.52%           
=======================================
  Files         444      444           
  Lines       30744    30744           
=======================================
  Hits        17687    17687           
  Misses      11443    11443           
  Partials     1614     1614           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@RongGu RongGu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Dec 31, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RongGu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cheyang cheyang merged commit 5cef3ac into fluid-cloudnative:master Dec 31, 2025
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Read-all and Write-all permissions should not be used in .github/workflows/sonarcloud.yaml.

3 participants