Draft
Conversation
- created configuration for multiple instances of telemetry - created robust test case with dedicated TestKernel
- capture console commands telemetry - capture messenger telemetry - capture http kernel telemetry
… container - updated dependencies in website to be links from monorepo
stloyd
reviewed
Feb 7, 2026
Comment on lines
+143
to
+157
| ->scalarNode('version') | ||
| ->info('Instrumentation scope version') | ||
| ->defaultValue('unknown') | ||
| ->end() | ||
| ->scalarNode('schema_url') | ||
| ->info('Schema URL for semantic conventions') | ||
| ->defaultNull() | ||
| ->end() | ||
| ->arrayNode('attributes') | ||
| ->info('Additional scope attributes') | ||
| ->normalizeKeys(false) | ||
| ->useAttributeAsKey('name') | ||
| ->prototype('variable')->end() | ||
| ->end() | ||
| ->end() |
Member
There was a problem hiding this comment.
Do we need some validation over those? Like if schema is URL-like etc?
| ->info('HTTP kernel request tracing configuration') | ||
| ->canBeEnabled() | ||
| ->children() | ||
| ->arrayNode('exclude_routes') |
Member
There was a problem hiding this comment.
With routes, it's tricky to cover them well cause you sometimes want to exclude, i.e., 401/403/404, but you still want to have 200 covered
| return $transportServiceId; | ||
| } | ||
|
|
||
| $endpoint = $config['endpoint'] ?? 'http://localhost:4318'; |
Member
There was a problem hiding this comment.
I think you enforce values on the configuration level, no?
Comment on lines
+73
to
+75
| $parts = \explode('\\', $className); | ||
|
|
||
| return \end($parts); |
Member
There was a problem hiding this comment.
Suggested change
| $parts = \explode('\\', $className); | |
| return \end($parts); | |
| return \substr(\strrchr($className, '\\'), 1); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #xxx
Change Log
Added
Fixed
Changed
Removed
Deprecated
Security