For compattibility with Url::asset() and Html::style/script()#49
Open
arturmamedov wants to merge 2 commits intofloatingpointsoftware:masterfrom
Open
For compattibility with Url::asset() and Html::style/script()#49arturmamedov wants to merge 2 commits intofloatingpointsoftware:masterfrom
arturmamedov wants to merge 2 commits intofloatingpointsoftware:masterfrom
Conversation
Why?
Because when we install Laravel in to a sub folder (ex: /laravelapp) we need to refer all our assets urls to this subfolder.
And laravel stuff yet do this in example `Html::script('')` return `http://domain.com/laravelapp` because it look what is set in `app.asset_url`
Also all other `Theme::style/script/image/linkAsset()` will return url with subfolder included `http://domain.com/laravelapp`
But not for `Theme::url()` that use `url() helper` of Laravel that generate url from root and not in accord of condif `app.asset_url` so we need to replace it to `asset()` that work with asset and not app url's
Author
|
Or another proposal can be the creation of |
Set root url to `/subfolder` and check if theme builder return correct path to assets also in it
Author
|
This test is not correct anyway :( cause i can't reproduce the subfolder installation in test. Laravel set |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
Because when we install Laravel in to a sub folder (ex: /laravelapp) we need to refer all our assets urls to this subfolder.
And laravel stuff yet do this in example
Html::script('')returnhttp://domain.com/laravelappbecause it look what is set inapp.asset_urlAlso all other
Theme::style/script/image/linkAsset()will return url with subfolder includedhttp://domain.com/laravelappBut not for
Theme::url()that useurl() helperof Laravel that generate url from root and not in accord with configapp.asset_urlso we need to replace it to
asset()that work with assets and not app root url