Open
Conversation
…n dialog - Add X icon delete button to each dapp item in main dapps view - Implement two-step confirmation flow to prevent accidental deletions - Style delete buttons and confirmation dialog using Frame's design system - Integrate with existing tray:removeOrigin action for state management - Add proper event handling to prevent navigation conflicts
- Uncomment and style the Remove Dapp button in DappDetails view - Use consistent styling with permissions moduleButton pattern - Apply destructive action styling with red color - Ensure proper navigation back to main dapps list after removal
- Remove delete buttons from permissions views (DappsExpanded/DappsPreview) - Clean up unused removePermission store action and related CSS - Keep focused implementation with main dapps list and detail view removal only - Permissions view retains original toggle-only functionality
|
this is a really helpful UI tweak, hoping you are still able to maintain the contributions and reviews here and there @floating ? |
Owner
|
Yeah, we're still maintaining the current version until we release the new stuff. We can take a look at this tomorrow if it's something people are wanting. |
|
sounds great 👏🏻 - excited to hear you are all actively working on new stuff! Would love to also hear more if you have any address book type feature in the works. thanks for the quick reply! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1719
Preview
'x' Button in Dapps list
Deletion Confirmation