Open
Conversation
yarinvak
requested review from
YoavBZ and
idanya
and removed request for
YoavBZ
YoavBZ
reviewed
Feb 17, 2023
| this.axiosInstance.interceptors.request.use(async (config: any) => { | ||
| config.headers.common["X-API-Key"] = await this.authProvider.getApiKey(); | ||
| config.headers.common["User-Agent"] = this.getUserAgent(); | ||
| return config; |
Collaborator
There was a problem hiding this comment.
Why should we run this on every request? These header don't change. But if we already have an interceptor, let's move signJwt() into it
Contributor
Author
There was a problem hiding this comment.
Where do you suggest calculating it if not here? It's an async function, can't execute it in the constructor
Collaborator
There was a problem hiding this comment.
I agree.
We should move sign_jwt() in here as well.
This way the consumer can use the same SDK instance to run commands on multiple accounts. Because the API Key and the JWT are coupled it makes little sense to allow changing only one.
|
Hi, any updates on this PR? Is this going to be merged eventually? Seems that progress/discussion has stopped. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Resolves #77
Type of change
How Has This Been Tested?
Checklist: