Use stm-containers to avoid contention in Vector#79
Open
parsonsmatt wants to merge 3 commits intofimad:masterfrom
Open
Use stm-containers to avoid contention in Vector#79parsonsmatt wants to merge 3 commits intofimad:masterfrom
parsonsmatt wants to merge 3 commits intofimad:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR switches the
Vectormetric away fromIORef (Map k v)to StmContainers.Map k v`, significantly improving performance in concurrent modification.This is a breaking change with very slight impact: the constraint
Hashableis added to two functiosn which previously got by on mereLabel. SinceLabelappears to mostly be useful for tuples of texts, this should not break most use sites.I created benchmarks on my other fork with other memory improvements: parsonsmatt#1
stm-containersis faster with two threads and up; with high contention and lots of concurrent modification (as we expect to see in a webserver),stm-containerslevels out whileIORef (Map k v)runs into massive concurrency contention.In the other PR, I left the old implementation, and switched the default. In this PR I've simply used the faster implementation. I don't think the meager performance benefit in single threaded applications is worth complicating the code in library.
This is also a fix to #75