Enhance/precompile resolveaddress #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjmelements
reviewed
Dec 10, 2025
|
|
||
| import {RESOLVE_ADDRESS} from "./FVMPrecompiles.sol"; | ||
|
|
||
| library FVMAddress { |
Collaborator
There was a problem hiding this comment.
Because this overlaps with #3, I think it makes sense for library FVMAddress to be one pull request.
wjmelements
reviewed
Dec 14, 2025
| pragma solidity ^0.8.30; | ||
|
|
||
| contract FVMResolveAddress { | ||
| mapping(bytes32 => uint64) public addressMocks; |
wjmelements
reviewed
Dec 14, 2025
| import {FVMGetBeaconRandomness} from "./FVMGetBeaconRandomness.sol"; | ||
| import {FVMResolveAddress} from "./FVMResolveAddress.sol"; | ||
|
|
||
| /// @notice Mocks the FVM precompiles for forge test |
Collaborator
There was a problem hiding this comment.
I want to keep this. Why do you remove it?
wjmelements
reviewed
Dec 14, 2025
| mapping(bytes32 => uint64) public addressMocks; | ||
| mapping(bytes32 => bool) public addressExists; | ||
|
|
||
| function mockResolveAddress(bytes memory filAddress, uint64 actorId) external { |
Collaborator
There was a problem hiding this comment.
also provide a helper for mocking address that converts the address to f4
wjmelements
reviewed
Dec 14, 2025
| library FVMAddress { | ||
| function resolveAddress(bytes memory filAddress) internal view returns (bool success, uint64 actorId) { | ||
| bytes memory result; | ||
| (success, result) = address(RESOLVE_ADDRESS).staticcall(filAddress); |
Collaborator
There was a problem hiding this comment.
RESOLVE_ADDRESS is already an address and doesn't need to be cast to address
wjmelements
reviewed
Dec 14, 2025
| function toActorId(bytes memory filAddress) internal view returns (uint64 actorId) { | ||
| (bool success, uint64 id) = resolveAddress(filAddress); | ||
| require(success, "FVMAddress: Invalid address format"); | ||
| require(id != 0, "FVMAddress: Actor not found"); |
Collaborator
There was a problem hiding this comment.
0 is a valid ID. It is the id of the system actor.
wjmelements
reviewed
Dec 14, 2025
| import {RESOLVE_ADDRESS} from "./FVMPrecompiles.sol"; | ||
|
|
||
| library FVMAddress { | ||
| function resolveAddress(bytes memory filAddress) internal view returns (bool success, uint64 actorId) { |
Collaborator
There was a problem hiding this comment.
I think we should be returning exists rather than success. success is uninteresting because it only fails if the address is invalid. should revert in that case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1
@wjmelements
I’ve added full ResolveAddress precompile support with a spec-aligned FVMAddress library, a simple mock for testing, and full coverage for success, not-found, and invalid-address scenarios. Everything’s tested and formatted cleanly.