feat(dx_maint): sort output by start time of event #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the output was sorted by the date the event was published because AWS does not always provide a start time in events (I have no idea why). But for a series of maintenance events, sorting by the start time of the event makes more sense. In the event that AWS does not provide a start time, then we fallback to the time the event was published.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the output was sorted by the date the event was published because AWS does not always provide a start time in events (I have no idea why). But for a series of maintenance events, sorting by the start time of the event makes more sense. In the event that AWS does not provide a start time, then we fallback to the time the event was published.