Add optional Icon property to Goal model#96
Add optional Icon property to Goal model#96vamsi-trashgamingyt wants to merge 4 commits intofencer-so:mainfrom
Conversation
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| - | - | MongoDB Credentials | 42c2e78 | CommBank-Server/Secrets.json | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
This pull request updates the CommBank backend to support an optional Icon field on goals so the frontend can display goal icons.
Changes made:
Added a nullable Icon property to the Goal model so existing data stays compatible.
Updated configuration and secrets to point to the correct MongoDB Atlas cluster.
Adjusted goal controller tests to cover the new Icon field where applicable.
Testing:
Ran the API locally with dotnet run.
Used Postman to call the goals endpoint and confirmed responses still return correctly, including the icon field when present.