Adding optional goal icons to goal cards on the CommBank App; Testing included.#80
Adding optional goal icons to goal cards on the CommBank App; Testing included.#80StuvanFIT wants to merge 4 commits intofencer-so:mainfrom
Conversation
StuvanFIT
commented
Jul 24, 2025
- Displayed the selected emoji icon on each goal card (if available).
- Applied fallback styling if no icon is set.
- Integrated an emoji picker component for icon selection.
- Updated PUT /api/Goal/{id} to handle optional icon field.
- Added test coverage for updated GoalController PUT logic.
- Verified emoji picker functionality.
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| - | - | MongoDB Credentials | 353b29f | CommBank-Server/Secrets.json | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.