feat: Support staging for spark materialization (#5671) #5797
+374
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfw-ppi
force-pushed
the
5671-spark-staging-only
branch
from
fb985ae to
88636de
Compare
ntkathole
reviewed
Dec 31, 2025
| spark.sql.execution.arrow.pyspark.enabled: "true" | ||
| # Optional: spill large materializations to the staging location instead of collecting in the driver | ||
| staging_location: "s3://my-bucket/tmp/feast" | ||
| staging_allow_materialize: true |
Member
There was a problem hiding this comment.
Do you think staging_allow_materialize flag is redundant here? If staging_location is set, staging should likely be enabled by default.
Signed-off-by: Jacob Weinhold <29459386+jfw-ppi@users.noreply.github.com>
…st-dev#5671)) Signed-off-by: Jacob Weinhold <29459386+jfw-ppi@users.noreply.github.com>
ntkathole
force-pushed
the
5671-spark-staging-only
branch
from
b3ba611 to
e8e9163
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
#5671