Refactor auth, calendar, and nango API crates#3728
Merged
Conversation
- Extract shared env config types (SupabaseEnv, NangoEnv) into new api-env crate - Introduce AuthContext in api-auth middleware, removing duplicated extract_token helpers across crates - Move calendar routes and nango_http from api-nango to api-calendar where they belong - Add list_calendars and create_event endpoints to api-calendar - Replace hardcoded NangoIntegration enum with fluent client.integration().connection() API - Simplify config constructors to accept env structs directly Co-authored-by: Cursor <cursoragent@cursor.com>
✅ Deploy Preview for hyprnote canceled.
|
✅ Deploy Preview for hyprnote-storybook canceled.
|
Contributor
Author
|
Contains lot of learnings from #3665 |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SupabaseEnvandNangoEnvconfig types into newapi-envcrateAuthContext(token + claims) toapi-authmiddleware, remove all duplicatedextract_tokenhelpers fromapi-nangoandapi-subscriptionnango_httpfromapi-nangointoapi-calendarlist_calendarsandcreate_eventendpoints toapi-calendarNangoIntegrationenum with fluentclient.integration("...").connection("...")APIGoogleCalendar,CreateEventBody,CreateEventRequesttypes togoogle-calendarcrateMade with Cursor