fix: add ignored field to timelineEvents query for proper reactivity#3632
Open
devin-ai-integration[bot] wants to merge 3 commits intomainfrom
Open
fix: add ignored field to timelineEvents query for proper reactivity#3632devin-ai-integration[bot] wants to merge 3 commits intomainfrom
devin-ai-integration[bot] wants to merge 3 commits intomainfrom
Conversation
…ivity The TinyBase query was using 'ignored' in its WHERE clause but not selecting it, which could cause the query to not properly react to changes in the ignored field. This fixes the issue where clicking 'Ignore this event' sometimes didn't work. Co-Authored-By: john@hyprnote.com <john@hyprnote.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
✅ Deploy Preview for hyprnote-storybook canceled.
|
✅ Deploy Preview for hyprnote ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Co-Authored-By: john@hyprnote.com <john@hyprnote.com>
…ignore-event-reactivity
devin-ai-integration
bot
changed the title
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue where clicking "Ignore this event" in the context menu sometimes doesn't work.
The
timelineEventsTinyBase query was using theignoredfield in its WHERE clause but not selecting it. This could prevent TinyBase from properly tracking changes to theignoredfield, causing the query to not re-run when an event is ignored.Change: Added
select("ignored")to thetimelineEventsquery definition.Review & Testing Checklist for Human
Notes
This is a hypothesis-based fix that wasn't tested locally. The root cause analysis suggests TinyBase may not track fields used in WHERE clauses unless they're also selected, but this should be verified by testing.
Requested by: @ComputelessComputer
Link to Devin run: https://app.devin.ai/sessions/e6a2d44e1e704b1b90fdecdf969dc281