fix: sync participants immediately when session is created from event#3578
Closed
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Closed
fix: sync participants immediately when session is created from event#3578devin-ai-integration[bot] wants to merge 1 commit intomainfrom
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Conversation
When a session is created from an event via getOrCreateSessionForEventId, participants are now synced immediately instead of waiting for the next calendar sync cycle (up to 60 seconds). Changes: - Add syncParticipantsForSession function to sync participants for a single session - Add fetchEventParticipants function to fetch participants from Apple Calendar - Call syncEventParticipantsToSession after creating a new session from an event This fixes the issue where the event metadata chip would show empty participants because the session was created outside the calendar sync flow. Co-Authored-By: john@hyprnote.com <john@hyprnote.com>
✅ Deploy Preview for hyprnote canceled.
|
✅ Deploy Preview for hyprnote-storybook canceled.
|
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue where the event metadata chip would show empty participants when a session was created from an event. The root cause was a timing issue: sessions created via
getOrCreateSessionForEventIddidn't get participants until the next calendar sync cycle (up to 60 seconds later).This PR adds immediate participant syncing when a new session is created from an event by:
fetchEventParticipantsto fetch participants for a specific event from Apple CalendarsyncParticipantsForSessionto sync participants for a single session (reuses existingcomputeSessionParticipantChangeslogic)Review & Testing Checklist for Human
syncEventParticipantsToSessionfunction has multiple early returns with no logging - verify this is acceptable behaviorRecommended Test Plan
Notes
void syncEventParticipantsToSession(...)) - failures are silentstore as MergeableStoretype assertion due to TinyBase type differencescomputeSessionParticipantChangeslogic respects excluded participants and only modifiessource: "auto"mappingsLink to Devin run: https://app.devin.ai/sessions/cf67ab4469c746a79a12846bf1f6e56e
Requested by: @ComputelessComputer