-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
build(deps): replace proxy-addr with @fastify/proxy-addr
#5913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Node: 20 Node: 22 |
|
Node: 20 Node: 22 |
|
Fastify version bench: > /Users/gurgunday/.nvm/versions/node/v22.12.0/bin/node benchmark/compiling.js
2 tests completed.
re-compiling x 266,204 ops/sec ±1.59% (192 runs sampled)
pre-compiling x 1,378,355 ops/sec ±0.26% (197 runs sampled)
> /Users/gurgunday/.nvm/versions/node/v22.12.0/bin/node benchmark/kind.js
3 tests completed.
ipv4 x 1,434,307 ops/sec ±1.45% (192 runs sampled)
ipv4-mapped x 437,080 ops/sec ±0.09% (196 runs sampled)
ipv6 x 554,847 ops/sec ±1.43% (195 runs sampled)
> /Users/gurgunday/.nvm/versions/node/v22.12.0/bin/node benchmark/matching.js
6 tests completed.
trust none x 22,475,003 ops/sec ±1.70% (190 runs sampled)
trust all x 46,984,338 ops/sec ±0.56% (195 runs sampled)
trust single x 1,434,945 ops/sec ±1.41% (195 runs sampled)
trust first x 46,407,961 ops/sec ±0.53% (191 runs sampled)
trust subnet x 1,460,830 ops/sec ±0.10% (195 runs sampled)
trust multiple x 1,441,307 ops/sec ±1.34% (197 runs sampled)original: > /Users/gurgunday/.nvm/versions/node/v22.12.0/bin/node benchmark/compiling.js
2 tests completed.
re-compiling x 288,284 ops/sec ±1.37% (195 runs sampled)
pre-compiling x 1,524,601 ops/sec ±0.95% (193 runs sampled)
> /Users/gurgunday/.nvm/versions/node/v22.12.0/bin/node benchmark/kind.js
3 tests completed.
ipv4 x 1,501,259 ops/sec ±1.68% (196 runs sampled)
ipv4-mapped x 433,521 ops/sec ±0.42% (196 runs sampled)
ipv6 x 518,953 ops/sec ±1.39% (195 runs sampled)
> /Users/gurgunday/.nvm/versions/node/v22.12.0/bin/node benchmark/matching.js
6 tests completed.
trust none x 7,870,762 ops/sec ±1.36% (191 runs sampled)
trust all x 9,507,996 ops/sec ±1.41% (195 runs sampled)
trust single x 1,507,601 ops/sec ±0.11% (193 runs sampled)
trust first x 9,572,051 ops/sec ±1.34% (197 runs sampled)
trust subnet x 1,570,250 ops/sec ±0.08% (196 runs sampled)
trust multiple x 1,541,185 ops/sec ±1.24% (197 runs sampled) |
mcollina
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
As mentioned in fastify/proxy-addr#52,
@fastify/proxy-addris faster thanproxy-addrdue to the@fastify/forwardedfork.Checklist
npm run testandnpm run benchmarkand the Code of conduct