Fix zsh completion to respect ZDOTDIR env var#1553
Open
Fridayai700 wants to merge 1 commit intofastapi:masterfrom
Open
Fix zsh completion to respect ZDOTDIR env var#1553Fridayai700 wants to merge 1 commit intofastapi:masterfrom
Fridayai700 wants to merge 1 commit intofastapi:masterfrom
Conversation
Closes fastapi#171 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of changes
AI?
Checklist
Description
Fixes #171
When installing zsh autocompletion,
install_zsh()hardcodedPath.home()for both.zshrcand.zfunc/paths. This ignores theZDOTDIRenvironment variable, which zsh uses to locate user startup files.The fix:
os.environ.get("ZDOTDIR")and use it as the base directory when setPath.home()whenZDOTDIRis not set (preserving existing behavior)$ZDOTDIR/.zfuncin the fpath line when ZDOTDIR is set (zsh expands this at startup),~/.zfuncotherwiseTest added:
test_completion_install_zsh_zdotdir— creates a temp directory as ZDOTDIR, runs completion install, verifies.zshrcand.zfunc/are created in the ZDOTDIR location.All existing completion install tests continue to pass.