[pull] main from containerd:main #307
Open
+21,424
−4,459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add nerdctl start with checkpoint command reference. Signed-off-by: ChengyuZhu6 <hudson@cyzhu.com>
install criu in ci to test checkpoint. Signed-off-by: ChengyuZhu6 <hudson@cyzhu.com>
introduce taskoptions to reduce argument numbers.
Otherwise, ci would be failed by:
```
Error: pkg/taskutil/taskutil.go:51:1: argument-limit:
maximum number of arguments per function exceeded; max 12 but got 13
func NewTask(ctx context.Context, client *containerd.Client,
container containerd.Container, attachStreamOpt []string,
isInteractive, isTerminal, isDetach bool, con console.Console,
logURI, detachKeys, namespace string, detachC chan<- struct{}, checkpointDir string)
```
Signed-off-by: ChengyuZhu6 <hudson@cyzhu.com>
Write com.docker.compose.config-hash label on create/run. Fixes: #4547 Signed-off-by: ChengyuZhu6 <hudson@cyzhu.com>
- TestComposeCreateWritesConfigHashLabel: verify config-hash label is written - TestComposeUpNoRecreateDependencies: ensure dependencies aren't recreated Signed-off-by: ChengyuZhu6 <hudson@cyzhu.com>
compose: align convergence with Docker Compose
Currently, nerdctl CI uses docker 28.0.4, while docker version 28.x has a known regression that breaks Checkpoint/Restore functionality. The issue is tracked in the moby/moby project as moby/moby#50750. Signed-off-by: ChengyuZhu6 <hudson@cyzhu.com>
The nerdctl-full tarball was incorrectly creating symlinks for all files in libexec/cni/, including documentation files like README.md and LICENSE. This resulted in non-executable files appearing in bin/ as buildkit-cni-README.md and buildkit-cni-LICENSE. Add executable and regular file checks to the symlink creation loop to filter out non-executable files. The fix uses [ -x "$f" ] to check for execute permission and [ -f "$f" ] to ensure it's a regular file, so only actual CNI plugin binaries are symlinked. Tested: bin/ file count reduced from 46 to 44 files (removed 2 doc symlinks). All 18 CNI plugin executables still correctly symlinked. Fixes #4553 Signed-off-by: Sadique Azmi <sadiquemobaraka5@gmail.com>
fix: filter non-executable files when symlinking buildkit-cni plugins (#4553)
Signed-off-by: ChengyuZhu6 <hudson@cyzhu.com>
checkpoint: support checkpoint create command
Bumps [github.com/containerd/nydus-snapshotter](https://github.com/containerd/nydus-snapshotter) from 0.15.5 to 0.15.6. - [Release notes](https://github.com/containerd/nydus-snapshotter/releases) - [Commits](containerd/nydus-snapshotter@v0.15.5...v0.15.6) --- updated-dependencies: - dependency-name: github.com/containerd/nydus-snapshotter dependency-version: 0.15.6 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
….com/containerd/nydus-snapshotter-0.15.6 build(deps): bump github.com/containerd/nydus-snapshotter from 0.15.5 to 0.15.6
Implement `nerdctl checkpoint ls` command to list checkpoints for a container, matching Docker's output format with "CHECKPOINT NAME" header. Signed-off-by: ChengyuZhu6 <hudson@cyzhu.com>
add unit test for checkpoint ls. Signed-off-by: ChengyuZhu6 <hudson@cyzhu.com>
add checkpoint list command reference. Signed-off-by: ChengyuZhu6 <hudson@cyzhu.com>
Fix: namestore directory regression - restore 'names' subdirectory in path
checkpoint: support checkpoint ls command
Bumps [github.com/containerd/cgroups/v3](https://github.com/containerd/cgroups) from 3.0.5 to 3.1.0. - [Release notes](https://github.com/containerd/cgroups/releases) - [Commits](containerd/cgroups@v3.0.5...v3.1.0) --- updated-dependencies: - dependency-name: github.com/containerd/cgroups/v3 dependency-version: 3.1.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [github.com/ipfs/go-cid](https://github.com/ipfs/go-cid) from 0.5.0 to 0.6.0. - [Release notes](https://github.com/ipfs/go-cid/releases) - [Commits](ipfs/go-cid@v0.5.0...v0.6.0) --- updated-dependencies: - dependency-name: github.com/ipfs/go-cid dependency-version: 0.6.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [github.com/containerd/nydus-snapshotter](https://github.com/containerd/nydus-snapshotter) from 0.15.6 to 0.15.7. - [Release notes](https://github.com/containerd/nydus-snapshotter/releases) - [Commits](containerd/nydus-snapshotter@v0.15.6...v0.15.7) --- updated-dependencies: - dependency-name: github.com/containerd/nydus-snapshotter dependency-version: 0.15.7 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
support checkpoint rm command. Signed-off-by: ChengyuZhu6 <hudson@cyzhu.com>
….com/ipfs/go-cid-0.6.0 build(deps): bump github.com/ipfs/go-cid from 0.5.0 to 0.6.0
….com/containerd/cgroups/v3-3.1.0 build(deps): bump github.com/containerd/cgroups/v3 from 3.0.5 to 3.1.0
….com/containerd/nydus-snapshotter-0.15.7 build(deps): bump github.com/containerd/nydus-snapshotter from 0.15.6 to 0.15.7
add unit test for checkpoint rm Signed-off-by: ChengyuZhu6 <hudson@cyzhu.com>
add checkpoint remove command reference. Signed-off-by: ChengyuZhu6 <hudson@cyzhu.com>
unexport subcommand Signed-off-by: ChengyuZhu6 <hudson@cyzhu.com>
checkpoint: support checkpoint rm command
Signed-off-by: Hajime Ogi <robertcal900@gmail.com>
Signed-off-by: Hayato Kiwata <dev@haytok.jp>
Bumps [github.com/containerd/accelerated-container-image](https://github.com/containerd/accelerated-container-image) from 1.3.0 to 1.4.0. - [Release notes](https://github.com/containerd/accelerated-container-image/releases) - [Commits](containerd/accelerated-container-image@v1.3.0...v1.4.0) --- updated-dependencies: - dependency-name: github.com/containerd/accelerated-container-image dependency-version: 1.4.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
….com/go-viper/mapstructure/v2-2.5.0 build(deps): bump github.com/go-viper/mapstructure/v2 from 2.4.0 to 2.5.0
…tions/setup-go-6.2.0 build(deps): bump actions/setup-go from 6.1.0 to 6.2.0
….com/containerd/accelerated-container-image-1.4.0 build(deps): bump github.com/containerd/accelerated-container-image from 1.3.0 to 1.4.0
Bumps the golang-x group with 2 updates: [golang.org/x/crypto](https://github.com/golang/crypto) and [golang.org/x/net](https://github.com/golang/net). Updates `golang.org/x/crypto` from 0.46.0 to 0.47.0 - [Commits](golang/crypto@v0.46.0...v0.47.0) Updates `golang.org/x/net` from 0.48.0 to 0.49.0 - [Commits](golang/net@v0.48.0...v0.49.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-version: 0.47.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: golang-x - dependency-name: golang.org/x/net dependency-version: 0.49.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: golang-x ... Signed-off-by: dependabot[bot] <support@github.com>
…time_linux_test.go test: refactor container_run_runtime_linux_test.go to use Tigron
…test.go test: refactor compose_pause_linux_test.go to use Tigron
…-x-75fb07cb15 build(deps): bump the golang-x group with 2 updates
Bumps [github.com/containerd/accelerated-container-image](https://github.com/containerd/accelerated-container-image) from 1.4.0 to 1.4.1. - [Release notes](https://github.com/containerd/accelerated-container-image/releases) - [Commits](containerd/accelerated-container-image@v1.4.0...v1.4.1) --- updated-dependencies: - dependency-name: github.com/containerd/accelerated-container-image dependency-version: 1.4.1 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
….com/containerd/accelerated-container-image-1.4.1 build(deps): bump github.com/containerd/accelerated-container-image from 1.4.0 to 1.4.1
Signed-off-by: Joonsoo Won <wonjs0116@gmail.com>
Signed-off-by: Hajime Ogi <robertcal900@gmail.com>
Signed-off-by: Joonsoo Won <wonjs0116@gmail.com>
…ux_test.go test: refactor container_exec_linux_test.go to use Tigron
Bumps [actions/cache](https://github.com/actions/cache) from 5.0.1 to 5.0.2. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](actions/cache@9255dc7...8b402f5) --- updated-dependencies: - dependency-name: actions/cache dependency-version: 5.0.2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps the docker group with 1 update: [github.com/docker/cli](https://github.com/docker/cli). Updates `github.com/docker/cli` from 29.1.4+incompatible to 29.1.5+incompatible - [Commits](docker/cli@v29.1.4...v29.1.5) --- updated-dependencies: - dependency-name: github.com/docker/cli dependency-version: 29.1.5+incompatible dependency-type: direct:production update-type: version-update:semver-patch dependency-group: docker ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [github.com/klauspost/compress](https://github.com/klauspost/compress) from 1.18.2 to 1.18.3. - [Release notes](https://github.com/klauspost/compress/releases) - [Commits](klauspost/compress@v1.18.2...v1.18.3) --- updated-dependencies: - dependency-name: github.com/klauspost/compress dependency-version: 1.18.3 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…tions/cache-5.0.2 build(deps): bump actions/cache from 5.0.1 to 5.0.2
…-770e91bf3a build(deps): bump github.com/docker/cli from 29.1.4+incompatible to 29.1.5+incompatible in the docker group
…_windows_test.go test: refactor container_rename_windows_test.go to use Tigron
…_linux_test.go Refactor container_rename_linux_test.go to use Tigron
….com/klauspost/compress-1.18.3 build(deps): bump github.com/klauspost/compress from 1.18.2 to 1.18.3
Signed-off-by: Joonsoo Won <wonjs0116@gmail.com>
Bumps [github.com/compose-spec/compose-go/v2](https://github.com/compose-spec/compose-go) from 2.10.0 to 2.10.1. - [Release notes](https://github.com/compose-spec/compose-go/releases) - [Commits](compose-spec/compose-go@v2.10.0...v2.10.1) --- updated-dependencies: - dependency-name: github.com/compose-spec/compose-go/v2 dependency-version: 2.10.1 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
….com/compose-spec/compose-go/v2-2.10.1 build(deps): bump github.com/compose-spec/compose-go/v2 from 2.10.0 to 2.10.1
Signed-off-by: Joonsoo Won <wonjs0116@gmail.com>
…stemd_linux_test.go test: refactor container_run_systemd_linux_test.go to use Tigron
…_linux_test.go test: refactor container_update_linux_test.go to use Tigron
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
18 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )