Skip to content

Conversation

@SimenB
Copy link
Contributor

@SimenB SimenB commented Feb 5, 2022

I think this achieves what #375 wanted (use it if provided, but doesn't warn if missing)

@MichaelDeBoey
Copy link

CC/ @Daniel15 @ElonVolo @trivikr

@danilobuerger
Copy link

@cpojer @SimenB any chance to get this merged?

@revelt
Copy link

revelt commented Jul 14, 2022

once/if you merge this, consider closing #378

@bryanjtc
Copy link

Any update on this?

@Daniel15
Copy link
Member

Daniel15 commented Jan 6, 2023

Sure. This seems reasonable to me. Thanks.

@Daniel15 Daniel15 merged commit 1b89558 into facebook:main Jan 6, 2023
@SimenB SimenB deleted the patch-1 branch January 6, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants