Open
Conversation
…defines height on top level input.
Contributor
|
Hello and thanks, Is adding Cheers, |
Author
|
Hey Yes, i only needed the height fix to make it look correct Olav |
Contributor
|
Ok. I just applied the patch on a stock eZ Publish Community Project, and the appearance of the toolbar remains the same. I believe your fix helps in case of customization of the toolbar, which is good. I would however love to have both @cgjengedal 's and @dpobel 's quick view on this one ! Thanks Olav, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When specifying css like below, the image proportions look horrible in the toolbar itself.
This simple fix sets the responsibility to the input element back to the toolbar itself. It can be debated if it's wanted to use div#ezwt input instead, but as all input is not using images it might cause unintentional display problems other places.