This repository was archived by the owner on May 3, 2022. It is now read-only.
[Prototype] EZP-26309: Prototype the usage of REST Embedding in PlatformUI#687
Open
[Prototype] EZP-26309: Prototype the usage of REST Embedding in PlatformUI#687
Conversation
…odel is fully responsible of the parsing
sunpietro
reviewed
Oct 12, 2016
| callback(error, response); | ||
| return; | ||
| } | ||
| Y.Array.each(response.document.VersionList.VersionItem, function (versionItemHash) { |
Contributor
There was a problem hiding this comment.
Nitpick: response.document.VersionList.VersionItem.forEach() is a better, native way of doing it
Contributor
Author
There was a problem hiding this comment.
thanks for the nitpicking, but what about the core feature/implementation ? (In case, you missed it, that's only a Prototype)
Contributor
There was a problem hiding this comment.
@dpobel I'm going to check it ASAP. Very interesting approach.
sunpietro
reviewed
Oct 12, 2016
| var attrName, linkName; | ||
|
|
||
| if ( L.isObject(item) ) { | ||
| linkName = Y.Object.keys(item)[0]; |
Contributor
There was a problem hiding this comment.
Nitpick: Object.keys() works natively everywhere
This was referenced Oct 12, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.ez.no/browse/EZP-26309
Description
This is a prototype to use REST Embeddding (implemented in ezsystems/ezpublish-kernel#1741) in PlatformUI. It also requires ezsystems/ez-js-rest-client#79 in the JavaScript REST Client. This is done for 2 parts in PlatformUI:
Outcome
I see 2 issues in the current implementation:
Other than that, this is working well. The performance improvement on the dashboard block is really interesting and we could so the same in a lots of places! In terms of change, the big thing is in the JavaScript client where we need to change each and every method to accept a new parameter so that we can pass the custom header to request the embedding.