Conversation
012a1d4 to
06b991d
Compare
2abfc5c to
df232e8
Compare
|
Awesome! can't wait to see this in action with pagination support :) |
|
Any POV on how we should deal with Paging? Got feedback that PagerFanta is not really good compared to what we had in legacy, which was purely template based. But unsure on which reason that would be. |
|
@andrerom Probably PagerFanta can require more work if you want to theme your paginations, but other than that, i'm really happy with it :) |
|
I don't think we can really skip some sort of support for a Pager here. The fact that PagerFanta might not be right for everybody can be an issue. One way would be to make that extensible to some extent. It shouldn't be very complicated: the code that builds the actual result variable based on the search results can be refactored into an external service. We must support both pager & not pager (as it is, semantically, a QueryController option), and we should make sure that the pager implementation can easily be swapped with another one, by means of service container aliasing. |
Updates the blog view to use the QueryController.