[BUGFIX] Fix CI pipelines

.github/workflows/ci.yaml

@@ -107,7 +107,10 @@ jobs:
 
       - uses: cachix/install-nix-action@v17
         with:
-          nix_path: nixpkgs=channel:nixos-unstable
+          nix_path: nixpkgs=channel:nixos-unstable:phps=https://github.com/fossar/nix-phps/archive/master.tar.gz
+          extra_nix_config: |
+            trusted-public-keys = cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY= fossar.cachix.org-1:Zv6FuqIboeHPWQS7ysLCJ7UT7xExb4OE8c4LyGb5AsE=
+            substituters = https://cache.nixos.org/ https://fossar.cachix.org
 
       - name: Run Unit Tests PHP8.1
         run: nix-shell --arg phpVersion \"php81\" --pure --run project-test-unit
@@ -142,7 +145,10 @@ jobs:
 
       - uses: cachix/install-nix-action@v17
         with:
-          nix_path: nixpkgs=channel:nixos-unstable
+          nix_path: nixpkgs=channel:nixos-unstable:phps=https://github.com/fossar/nix-phps/archive/master.tar.gz
+          extra_nix_config: |
+            trusted-public-keys = cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY= fossar.cachix.org-1:Zv6FuqIboeHPWQS7ysLCJ7UT7xExb4OE8c4LyGb5AsE=
+            substituters = https://cache.nixos.org/ https://fossar.cachix.org
 
       - name: Run Acceptance Tests PHP8.1
         run: nix-shell --arg phpVersion \"php81\" --pure --run project-test-acceptance

Build/FunctionalTests.xml → Build/phpunit.xml.dist

@@ -2,9 +2,12 @@
 <phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" backupGlobals="true" bootstrap="../vendor/typo3/testing-framework/Resources/Core/Build/FunctionalTestsBootstrap.php" colors="true" stopOnError="false" stopOnFailure="false" stopOnIncomplete="false" stopOnSkipped="false" beStrictAboutTestsThatDoNotTestAnything="false" xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/10.1/phpunit.xsd" cacheDirectory=".phpunit.cache" requireCoverageMetadata="false">
   <coverage/>
   <testsuites>
-    <testsuite name="Cart Products Extension">
+    <testsuite name="functional">
       <directory>../Tests/Functional/</directory>
     </testsuite>
+    <testsuite name="unit">
+      <directory>../Tests/Unit/</directory>
+    </testsuite>
   </testsuites>
   <source>
     <include>

Classes/Controller/ProductController.php

@@ -82,8 +82,8 @@ protected function createDemandObjectFromSettings(array $settings): ProductDeman
         }
         if ($settings['orderBy']) {
             if (
-                !isset($settings['orderDirection']) &&
-                $settings['orderDirection'] !== 'DESC'
+                !isset($settings['orderDirection'])
+                && $settings['orderDirection'] !== 'DESC'
             ) {
                 $settings['orderDirection'] = 'ASC';
             }

Classes/Domain/Model/Product/BeVariant.php

@@ -98,8 +98,8 @@ public function getPriceCalculated(): float
         };
 
         if (
-            isset($GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['cart']['changeVariantDiscount']) &&
-            is_array($GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['cart']['changeVariantDiscount'])
+            isset($GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['cart']['changeVariantDiscount'])
+            && is_array($GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['cart']['changeVariantDiscount'])
         ) {
             foreach ($GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['cart']['changeVariantDiscount'] as $funcRef) {
                 if ($funcRef) {
@@ -144,8 +144,8 @@ public function getBestPriceCalculated($frontendUserGroupIds = []): float
         };
 
         if (
-            isset($GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['cart']['changeVariantDiscount']) &&
-            is_array($GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['cart']['changeVariantDiscount'])
+            isset($GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['cart']['changeVariantDiscount'])
+            && is_array($GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['cart']['changeVariantDiscount'])
         ) {
             foreach ($GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['cart']['changeVariantDiscount'] as $funcRef) {
                 if ($funcRef) {
@@ -226,8 +226,8 @@ public function getBestSpecialPrice(array $frontendUserGroupIds = []): ?SpecialP
 
         foreach ($this->getSpecialPrices() as $specialPrice) {
             if ($bestSpecialPrice === null) {
-                if (!$specialPrice->getFrontendUserGroup() ||
-                    in_array($specialPrice->getFrontendUserGroup()->getUid(), $frontendUserGroupIds)
+                if (!$specialPrice->getFrontendUserGroup()
+                    || in_array($specialPrice->getFrontendUserGroup()->getUid(), $frontendUserGroupIds)
                 ) {
                     $bestSpecialPrice = $specialPrice;
                 }
@@ -236,16 +236,16 @@ public function getBestSpecialPrice(array $frontendUserGroupIds = []): ?SpecialP
 
             if (
                 (
-                    ($specialPrice->getPrice() < $bestSpecialPrice->getPrice()) &&
-                    in_array($this->priceCalcMethod, [0, 1, 4, 5])
-                ) ||
-                (
-                    ($specialPrice->getPrice() > $bestSpecialPrice->getPrice()) &&
-                    in_array($this->priceCalcMethod, [2, 3])
+                    ($specialPrice->getPrice() < $bestSpecialPrice->getPrice())
+                    && in_array($this->priceCalcMethod, [0, 1, 4, 5])
+                )
+                || (
+                    ($specialPrice->getPrice() > $bestSpecialPrice->getPrice())
+                    && in_array($this->priceCalcMethod, [2, 3])
                 )
             ) {
-                if (!$specialPrice->getFrontendUserGroup() ||
-                    in_array($specialPrice->getFrontendUserGroup()->getUid(), $frontendUserGroupIds)
+                if (!$specialPrice->getFrontendUserGroup()
+                    || in_array($specialPrice->getFrontendUserGroup()->getUid(), $frontendUserGroupIds)
                 ) {
                     $bestSpecialPrice = $specialPrice;
                 }
@@ -263,12 +263,12 @@ public function getBestPrice(array $frontendUserGroupIds = []): float
         if ($bestSpecialPrice) {
             if (
                 (
-                    ($bestSpecialPrice->getPrice() < $bestPrice) &&
-                    in_array($this->priceCalcMethod, [0, 1, 4, 5])
-                ) ||
-                (
-                    ($bestSpecialPrice->getPrice() > $bestPrice) &&
-                    in_array($this->priceCalcMethod, [2, 3])
+                    ($bestSpecialPrice->getPrice() < $bestPrice)
+                    && in_array($this->priceCalcMethod, [0, 1, 4, 5])
+                )
+                || (
+                    ($bestSpecialPrice->getPrice() > $bestPrice)
+                    && in_array($this->priceCalcMethod, [2, 3])
                 )
             ) {
                 $bestPrice = $bestSpecialPrice->getPrice();
@@ -301,9 +301,9 @@ public function getBasePrice(): ?float
     {
         //TODO: respects different measuring units between variant and product
         if (
-            !$this->product ||
-            !$this->product->getIsMeasureUnitCompatibility() ||
-            !$this->getPriceMeasure() > 0
+            !$this->product
+            || !$this->product->getIsMeasureUnitCompatibility()
+            || !$this->getPriceMeasure() > 0
         ) {
             return null;
         }
@@ -424,20 +424,20 @@ public function getTitle(): string
         $titleArray = [];
 
         if ($this->getProduct()->getBeVariantAttribute1()) {
-            $titleArray[] =
-                $this->getProduct()->getBeVariantAttribute1()->getTitle()
+            $titleArray[]
+                = $this->getProduct()->getBeVariantAttribute1()->getTitle()
                 . ' '
                 . $this->getBeVariantAttributeOption1()->getTitle();
         }
         if ($this->getProduct()->getBeVariantAttribute2()) {
-            $titleArray[] =
-                $this->getProduct()->getBeVariantAttribute2()->getTitle()
+            $titleArray[]
+                = $this->getProduct()->getBeVariantAttribute2()->getTitle()
                 . ' '
                 . $this->getBeVariantAttributeOption2()->getTitle();
         }
         if ($this->getProduct()->getBeVariantAttribute3()) {
-            $titleArray[] =
-                $this->getProduct()->getBeVariantAttribute3()->getTitle()
+            $titleArray[]
+                = $this->getProduct()->getBeVariantAttribute3()->getTitle()
                 . ' '
                 . $this->getBeVariantAttributeOption3()->getTitle();
         }

Classes/Domain/Model/Product/Product.php

@@ -194,8 +194,8 @@ public function getBestSpecialPrice(array $frontendUserGroupIds = []): float
         foreach ($this->specialPrices as $specialPrice) {
             if ($specialPrice->getPrice() < $bestSpecialPrice) {
                 if (
-                    !$specialPrice->getFrontendUserGroup() ||
-                    in_array($specialPrice->getFrontendUserGroup()->getUid(), $frontendUserGroupIds)
+                    !$specialPrice->getFrontendUserGroup()
+                    || in_array($specialPrice->getFrontendUserGroup()->getUid(), $frontendUserGroupIds)
                 ) {
                     $bestSpecialPrice = $specialPrice->getPrice();
                 }
@@ -238,8 +238,8 @@ public function getQuantityDiscountArray(array $frontendUserGroupIds = []): arra
 
         if ($this->getQuantityDiscounts()) {
             foreach ($this->getQuantityDiscounts() as $quantityDiscount) {
-                if (!$quantityDiscount->getFrontendUserGroup() ||
-                    in_array($quantityDiscount->getFrontendUserGroup()->getUid(), $frontendUserGroupIds)
+                if (!$quantityDiscount->getFrontendUserGroup()
+                    || in_array($quantityDiscount->getFrontendUserGroup()->getUid(), $frontendUserGroupIds)
                 ) {
                     $quantityDiscountArray[] = $quantityDiscount->toArray();
                 }

Classes/Domain/Repository/CategoryRepository.php

@@ -31,8 +31,8 @@ public function findAllAsArray(?Category $selectedCategory = null): array
             $newCategory = [
                 'uid' => $localCategory->getUid(),
                 'title' => $localCategory->getTitle(),
-                'parent' =>
-                    ($localCategory->getParent() ? $localCategory->getParent()->getUid() : null),
+                'parent'
+                    => ($localCategory->getParent() ? $localCategory->getParent()->getUid() : null),
                 'subcategories' => null,
                 'isSelected' => ($selectedCategory === $localCategory),
             ];
@@ -47,8 +47,8 @@ public function findSubcategoriesRecursiveAsArray(?Category $parentCategory = nu
         $localCategories = $this->findAllAsArray();
         foreach ($localCategories as $category) {
             if (
-                !$parentCategory ||
-                $category['uid'] === $parentCategory->getUid()
+                !$parentCategory
+                || $category['uid'] === $parentCategory->getUid()
             ) {
                 $this->getSubcategoriesIds(
                     $localCategories,
@@ -83,8 +83,8 @@ protected function buildSubcategories(array $categoriesArray, array $parentCateg
         foreach ($categoriesArray as $category) {
             if ($category['parent'] === $parentCategory['uid']) {
                 $newCategory = $category;
-                $newCategory['subcategories'] =
-                    $this->buildSubcategories($categoriesArray, $category);
+                $newCategory['subcategories']
+                    = $this->buildSubcategories($categoriesArray, $category);
                 $categories[] = $newCategory;
             }
         }

Classes/Domain/Repository/Product/ProductRepository.php

@@ -74,15 +74,15 @@ protected function createOrderingsFromDemand(ProductDemand $demand): array
 
         if (!empty($orderList)) {
             foreach ($orderList as $orderItem) {
-                [$orderField, $orderDirection] =
-                    array_pad(
+                [$orderField, $orderDirection]
+                    = array_pad(
                         GeneralUtility::trimExplode(' ', $orderItem, true),
                         2,
                         'asc'
                     );
                 if (
-                    $orderDirection &&
-                    strtolower($orderDirection) === 'desc'
+                    $orderDirection
+                    && strtolower($orderDirection) === 'desc'
                 ) {
                     $orderings[$orderField] = QueryInterface::ORDER_DESCENDING;
                 } else {

Classes/EventListener/CheckProductAvailability.php

@@ -93,9 +93,9 @@ public function checkStockForBeVariant(CartProductBeVariant $cartProductBeVarian
         }
 
         if (
-            $mode === 'add' &&
-            $cart->getProductById($cartProduct->getId()) &&
-            $cart->getProductById($cartProduct->getId())->getBeVariantById($cartProductBeVariant->getId())
+            $mode === 'add'
+            && $cart->getProductById($cartProduct->getId())
+            && $cart->getProductById($cartProduct->getId())->getBeVariantById($cartProductBeVariant->getId())
         ) {
             $quantityInCart += $cart->getProductById($cartProduct->getId())->getBeVariantById($cartProductBeVariant->getId())->getQuantity();
         }

Classes/EventListener/Create/CheckRequest.php

@@ -22,8 +22,8 @@ public function __invoke(RetrieveProductsFromRequestEvent $event): void
         $request = $event->getRequest();
 
         if (
-            !$request->hasArgument('product') ||
-            !(int)$request->getArgument('product')
+            !$request->hasArgument('product')
+            || !(int)$request->getArgument('product')
         ) {
             $event->addError(
                 new FlashMessage(
@@ -39,8 +39,8 @@ public function __invoke(RetrieveProductsFromRequestEvent $event): void
         }
 
         if (
-            !$request->hasArgument('quantity') ||
-            $request->getArgument('quantity') < 0
+            !$request->hasArgument('quantity')
+            || $request->getArgument('quantity') < 0
         ) {
             $event->addError(
                 new FlashMessage(

Classes/Hooks/DatamapDataHandlerHook.php

@@ -96,11 +96,11 @@ protected function isAllowedTargetPage($listType, $doktype)
                 ($doktype === 183) && (
                     $listType === 'cartproducts_singleproduct'
                 )
-            ) ||
-            (
+            )
+            || (
                 ($doktype !== 183) && (
-                    $listType === 'cartproducts_products' ||
-                    $listType === 'cartproducts_slots'
+                    $listType === 'cartproducts_products'
+                    || $listType === 'cartproducts_slots'
                 )
             )
         ) {

Classes/Updates/SwitchableControllerActionsPluginUpdater.php

@@ -153,8 +153,8 @@ protected function getMigrationRecords(): array
     protected function getTargetListType(string $sourceListType, string $switchableControllerActions): string
     {
         foreach (self::MIGRATION_SETTINGS as $setting) {
-            if ($setting['sourceListType'] === $sourceListType &&
-                $setting['switchableControllerActions'] === $switchableControllerActions
+            if ($setting['sourceListType'] === $sourceListType
+                && $setting['switchableControllerActions'] === $switchableControllerActions
             ) {
                 return $setting['targetListType'];
             }

Classes/ViewHelpers/CanonicalTagViewHelper.php

@@ -54,8 +54,8 @@ public function render(): string
         }
 
         $arguments = [
-            ['tx_cartproducts_product' =>
-                [
+            ['tx_cartproducts_product'
+                => [
                     'controller' => 'Product',
                     'product' => $product->getUid(),
                 ],

Configuration/TCA/Overrides/tx_cartproducts_domain_model_product_product.php

@@ -21,9 +21,9 @@
 
     // prepend category restriction at the beginning of foreign_table_where
     if (!empty($categoryRestriction)) {
-        $GLOBALS['TCA']['tx_cartproducts_domain_model_product_product']['columns']['category']['config']['foreign_table_where'] = $categoryRestriction .
-            $GLOBALS['TCA']['tx_cartproducts_domain_model_product_product']['columns']['category']['config']['foreign_table_where'];
-        $GLOBALS['TCA']['tx_cartproducts_domain_model_product_product']['columns']['categories']['config']['foreign_table_where'] = $categoryRestriction .
-            $GLOBALS['TCA']['tx_cartproducts_domain_model_product_product']['columns']['categories']['config']['foreign_table_where'];
+        $GLOBALS['TCA']['tx_cartproducts_domain_model_product_product']['columns']['category']['config']['foreign_table_where'] = $categoryRestriction
+            . $GLOBALS['TCA']['tx_cartproducts_domain_model_product_product']['columns']['category']['config']['foreign_table_where'];
+        $GLOBALS['TCA']['tx_cartproducts_domain_model_product_product']['columns']['categories']['config']['foreign_table_where'] = $categoryRestriction
+            . $GLOBALS['TCA']['tx_cartproducts_domain_model_product_product']['columns']['categories']['config']['foreign_table_where'];
     }
 }