Do not check trailing white spaces on problem-specifications files #1610
Conversation
|
Thank you for contributing to Based on the files changed in this PR, it would be good to pay attention to the following details when reviewing the PR:
Automated comment created by PR Commenter 🤖. |
| # so we negate the result for consistency | ||
| ! git grep --line-number ' $' | ||
| # binaries and files directly copied from exercism/problem-specifications are ignored | ||
| ! git grep -I --line-number ' $' -- . \ |
There was a problem hiding this comment.
The -I flag ignores binary files, because without it the check always fails for exercises/concept/file-sniffer/assets/elf.o locally. I'm not sure why it doesn't fail on CI, maybe a different version of git, but it doesn't really make sense to format binaries anyway.
angelikatyborska
left a comment
angelikatyborska
left a comment
There was a problem hiding this comment.
Makes sense and works as expected. Thank you 🙌
See these comments.
I looked into the JS script, but things like
corepack pnpm dlxscare me 😆More importantly, I noticed on their .prettierignore file that they are actually ignoring the problem specs files, so I if we are going to ignore those files no matter what, we might as well start with this to fix the CI, and improve the formatting checks later.