Skip to content

🦺 server: handle optional panda wallets field#728

Merged
cruzdanilo merged 1 commit intomainfrom
panda
Feb 6, 2026
Merged

🦺 server: handle optional panda wallets field#728
cruzdanilo merged 1 commit intomainfrom
panda

Conversation

@cruzdanilo
Copy link
Member

@cruzdanilo cruzdanilo commented Feb 6, 2026

sentry issue: SERVER-CH


Open with Devin

Summary by CodeRabbit

  • Bug Fixes
    • Payment wallet field is now optional, improving flexibility for payment configuration handling.

@changeset-bot
Copy link

changeset-bot bot commented Feb 6, 2026

🦋 Changeset detected

Latest commit: f676383

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@exactly/server Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@gemini-code-assist
Copy link

Summary of Changes

Hello @cruzdanilo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a crucial schema adjustment to the panda hook, specifically making the tokenWallets field optional. This change is designed to enhance the robustness of the server by gracefully handling cases where this field may not be present in incoming data, thereby preventing errors and improving data parsing reliability.

Highlights

  • Schema Update: The tokenWallets field within the Payload schema in server/hooks/panda.ts has been updated to be optional, addressing potential issues where this field might be missing.
  • Changelog Entry: A new changeset file (.changeset/mighty-guests-knock.md) has been added to document this change as a patch release for the @exactly/server package.
Changelog
  • .changeset/mighty-guests-knock.md
    • Added a new changeset file to record this modification as a patch release for the @exactly/server package.
  • server/hooks/panda.ts
    • Modified the Payload schema to mark the tokenWallets field as optional, allowing for its absence without causing validation failures.
Activity
  • The pull request was created by cruzdanilo.
  • A Sentry issue (SERVER-CH) was linked in the PR description, indicating the problem this PR aims to resolve.
  • No other review comments or activity have been recorded yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@coderabbitai
Copy link

coderabbitai bot commented Feb 6, 2026

Walkthrough

Introduces a changeset bumping the patch version for "@exactly/server". Modifies the card update payload schema in server/hooks/panda.ts to make the tokenWallets field optional, allowing requests without tokenWallets while maintaining existing validation for Apple and Google Pay arrays when present.

Changes

Cohort / File(s) Summary
Changeset Entry
.changeset/mighty-guests-knock.md
Patch version bump for "@exactly/server" with changelog entry documenting optional panda wallets field.
Schema Validation
server/hooks/panda.ts
Updated card update payload schema to wrap tokenWallets field in v.optional(), making it no longer required while preserving the union of Apple and Google Pay array validation when present.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title accurately and clearly describes the main change: making the panda wallets field optional in the server code, which is precisely what the changeset and code modifications accomplish.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch panda

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sentry
Copy link

sentry bot commented Feb 6, 2026

Sentry Issue: SERVER-CH

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a fix for a Sentry issue by making the tokenWallets field optional in the Card schema. This change correctly handles cases where the tokenWallets field might be absent, improving the robustness of the application's data parsing logic. A new changeset file has also been added to document this modification.

Copy link

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional findings.

Open in Devin Review

@sentry
Copy link

sentry bot commented Feb 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.05%. Comparing base (d9866f9) to head (f676383).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #728   +/-   ##
=======================================
  Coverage   68.05%   68.05%           
=======================================
  Files         206      206           
  Lines        6784     6784           
  Branches     2117     2117           
=======================================
  Hits         4617     4617           
  Misses       1986     1986           
  Partials      181      181           
Flag Coverage Δ
e2e 52.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cruzdanilo cruzdanilo merged commit f676383 into main Feb 6, 2026
15 checks passed
@cruzdanilo cruzdanilo deleted the panda branch February 6, 2026 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant