Skip to content

Conversation

@erosselli
Copy link
Contributor

@erosselli erosselli commented Dec 22, 2025

Ticket []

Description Of Changes

Removes some async engine settings that don't work when you set them, since they're not supported by asyncpg; setting them causes the following error:

TypeError: connect() got an unexpected keyword argument 'keepalives_idle'

These settings were originally added in #6128 but that PR seems to only care about the pool_pre_ping setting which does work as usual.

Steps to Confirm

  1. N/A

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link

vercel bot commented Dec 22, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Review Updated (UTC)
fides-plus-nightly Ignored Ignored Preview Dec 23, 2025 0:42am
fides-privacy-center Ignored Ignored Dec 23, 2025 0:42am

@codecov
Copy link

codecov bot commented Dec 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.20%. Comparing base (cfbf98a) to head (34aa14f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7171      +/-   ##
==========================================
+ Coverage   87.17%   87.20%   +0.02%     
==========================================
  Files         535      535              
  Lines       35330    35315      -15     
  Branches     4113     4107       -6     
==========================================
- Hits        30800    30797       -3     
+ Misses       3639     3630       -9     
+ Partials      891      888       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@adamsachs adamsachs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the cleanup here!

Comment on lines +59 to +60
# Note: We purposely do not include async engine equivalents of the sync engine's
# keepalives_* settings as they are not supported by asyncpg.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@erosselli erosselli marked this pull request as ready for review December 23, 2025 12:21
@erosselli erosselli requested a review from a team as a code owner December 23, 2025 12:21
@erosselli erosselli requested review from vcruces and removed request for a team December 23, 2025 12:21
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Dec 23, 2025

Greptile Summary

Removed async engine keepalive configuration settings that were incompatible with asyncpg driver.

  • Removed api_async_engine_keepalives_idle, api_async_engine_keepalives_interval, and api_async_engine_keepalives_count fields from DatabaseSettings
  • Removed code in ctl_session.py that attempted to pass these unsupported parameters to create_async_engine()
  • Added explanatory comment noting that these settings are purposely excluded because they are not supported by asyncpg
  • Sync engine keepalive settings remain unchanged and continue to work correctly with psycopg2

The changes fix a runtime error (TypeError: connect() got an unexpected keyword argument 'keepalives_idle') that would occur when these settings were configured.

Confidence Score: 5/5

  • This PR is safe to merge with no risk
  • The changes are straightforward and correct: they remove non-functional configuration options that cause runtime errors when used. The removal is properly documented with an explanatory comment, and the equivalent sync engine keepalive settings remain unchanged. No tests need updating since these settings were never functional.
  • No files require special attention

Important Files Changed

Filename Overview
src/fides/api/db/ctl_session.py removed unsupported asyncpg keepalive settings from async engine configurations
src/fides/config/database_settings.py removed async keepalive config fields and added explanatory comment about asyncpg incompatibility

@erosselli erosselli removed the request for review from vcruces December 23, 2025 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants