MSFDG: adapt AttackV2 and StepV2 functions in op-challenger2 and alphabet E2E test#105
Open
MSFDG: adapt AttackV2 and StepV2 functions in op-challenger2 and alphabet E2E test#105
Conversation
…p-challenger2-attackv2
…allenger2-attackv2
…to bill/op-challenger2-attackv2
…to bill/op-challenger2-attackv2
This was referenced Nov 30, 2024
Collaborator
|
The description is too short for such a large change set IMO, could you elaborate in more detail so that the review can be easier? |
Author
Considering the extensive context, it might be better to split the changes into multiple PRs during a future rebase. For now, I suggest focusing on reviewing cosmetic aspects like naming and variable conventions, as that seems more feasible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
op-challenger2/game/fault/solver/solver_test.goandop-challenger2/game/fault/solver/game_solver_test.goTests