fix(p2p): handle pre-release versions in bee260 backward compatibility check #5327
+180
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y check The bee260BackwardCompatibility function was incorrectly treating pre-release versions (e.g., 2.7.0-rc12) as less than their stable counterparts (2.7.0) due to semver spec behavior. This caused nodes running 2.7.0-rc versions to incorrectly enable backward compatibility mode, stripping WSS addresses and limiting connections to TCP only. Changes: - Modified bee260BackwardCompatibility to compare only major.minor.patch by creating a clean version without pre-release metadata - Added debug logging for version compatibility decisions - Extracted bee260Compat variable in Connect and handleIncoming for clarity - Added comprehensive test coverage with 17 test cases including: * Legacy versions (< 2.7.0) requiring backward compat * Current/future versions (>= 2.7.0) not requiring backward compat * Pre-release versions (2.7.0-rcX) correctly treated as >= 2.7.0 * Edge cases (empty, malformed, non-bee user agents) Fixes browser node connectivity issues where they only received TCP addresses instead of both TCP and WSS addresses from peers running pre-release versions.
gacevicljubisa
requested review from
acud,
akrem-chabchoub,
janos and
martinconic
janos
approved these changes
Jan 23, 2026
pkg/p2p/libp2p/version_test.go
Outdated
| @@ -0,0 +1,165 @@ | |||
| // Copyright 2020 The Swarm Authors. All rights reserved. | |||
pkg/p2p/libp2p/libp2p.go
Outdated
| return false | ||
| } | ||
| result := vCore.LessThan(version270) | ||
| s.logger.Debug("bee version compatibility check", "peer_id", peerID, "version", version, "backward_compat", result) |
Member
There was a problem hiding this comment.
This log is great fro debugging, but would it be too frequent? Just guessing, maybe it is just fine to have it here especially for validating after the release on the mainnet.
akrem-chabchoub
approved these changes
Jan 23, 2026
martinconic
approved these changes
Jan 23, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
The bee260BackwardCompatibility function was incorrectly treating pre-release versions (e.g., 2.7.0-rc12) as less than their stable counterparts (2.7.0) due to semver spec behavior. This caused nodes running 2.7.0-rc versions to incorrectly enable backward compatibility mode, stripping WSS addresses and limiting connections to TCP only.
Changes:
Fixes browser node connectivity issues where they only received TCP addresses instead of both TCP and WSS addresses from peers running pre-release versions.
Open API Spec Version Changes (if applicable)
Motivation and Context (Optional)
Related Issue (Optional)
Screenshots (if appropriate):