-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Rebrand Arc Network to Arc following Archie Chain deprecation #7933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Rebrand Arc Network to Arc following Archie Chain deprecation #7933
Conversation
|
You successfully submitted a PR! Due to the amount of PRs coming in: we will only look at PRs that the CI is happy with. We can also not hold your hand getting the CI green - just look how others that where merged did it and RTFM. So as long as there is any CI check that reports an error - no human will look at this. You might be able to ask for some support after supporting the project - e.g. by sending funds to lists.eth. When you fixed things after a requested change - then you also need to (re-)request a review. |
85af4cd to
4307593
Compare
4307593 to
43ad572
Compare
_data/chains/eip155-1243.json
Outdated
| "name": "ARC Mainnet", | ||
| "name": "Archie Chain Mainnet", | ||
| "chain": "ARC", | ||
| "icon": "arc", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the icon was renamed, I imagine you want to remove these
FrederikBolding
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment
|
Hi @FrederikBolding Fixed! Removed the icon field from deprecated Archie Chain entries and changed their chain identifier from "ARC" to "Archie" so Arc Network can fully own the "ARC" chain identifier for both testnet and future mainnet. |
Summary
Rebranding Arc Network Testnet (Chain ID 5042002) to use the "Arc" branding now that Archie Chain (Chain IDs 1243, 1244) has been deprecated.
Background
Changes
Chain Configuration (
eip155-5042002.json)Validation
References