Draft
Conversation
11 tasks
|
@jesserockz could you take a look at this? |
13 tasks
jesserockz
approved these changes
Mar 31, 2024
jesserockz
requested changes
Mar 31, 2024
Member
jesserockz
left a comment
jesserockz
left a comment
There was a problem hiding this comment.
Just re-read the description and if this is so, then it should be a part of the dependencies in library.json.
It requires the use of the "AsyncTCP_RP2040W" package from here:
khoih-prog/AsyncTCP_RP2040W
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
FYI, I am maintaining since a few months now a fork which is more up to date, compatible with Arduino 2 and 3, and which is already used in many big projects around. https://github.com/mathieucarbou/ESPAsyncWebServer And we also have a working PR under test for RP2040: mathieucarbou/ESPAsyncWebServer#31 |
kuba2k2
pushed a commit
to libretiny-eu/ESPAsyncWebServer
that referenced
this pull request
May 27, 2025
* feat: Add pre-commit CI and sync formatting settings * fix: Ignore LICENSE file * fix: Apply new formatting * fix: Fix spelling and add spell checker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P2040: Add support for the RP2040.
This patch is a small patch that adds in the required ifdefs to make the async web server work on the RP2040 platform.
It requires the use of the "AsyncTCP_RP2040W" package from here:
https://github.com/khoih-prog/AsyncTCP_RP2040W
This pull request is being done in tandem with the main pull request on esphome here:
esphome/esphome#5305