Bug safari with Content-Encoding: gzip and Content-Disposition#16
Open
xlyric wants to merge 2 commits intoesphome:mainfrom
Open
Bug safari with Content-Encoding: gzip and Content-Disposition#16xlyric wants to merge 2 commits intoesphome:mainfrom
xlyric wants to merge 2 commits intoesphome:mainfrom
Conversation
|
@jesserockz : FYI @xlyric also warned me about this bug and the fix is something else: mathieucarbou/ESPAsyncWebServer@cfbe38c No filename after It is fixes in my fork https://github.com/mathieucarbou/ESPAsyncWebServer |
kuba2k2
pushed a commit
to libretiny-eu/ESPAsyncWebServer
that referenced
this pull request
May 27, 2025
kuba2k2
pushed a commit
to libretiny-eu/ESPAsyncWebServer
that referenced
this pull request
May 27, 2025
Update CI (also test with AsyncTCP#main)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hi,
the header Content-Disposition create a bug in this case :
explorer : Safari
html page called in mode gzip ( HTTP compress )
(
GET /index.html HTTP/1.1
Host: xxx
Accept-Encoding: gzip )
the librairie return a wrong"Content-Disposition" and expose a file who was not rerouted
ex :
the response header is wrong
and Content-Disposition: is not usefull in this case.
on all navigator except safari, the navigator skip this line. Safari try to call the wrong file.