Skip to content

Conversation

@finger563
Copy link
Contributor

@finger563 finger563 commented Jun 23, 2025

Description

  • Update to use v1.0.10 of esp-cpp/espp components, bringing in latest CLI / updates from feat(wifi): Flesh out AP + STA and add menus for control/config espp#462
  • Refactor main code to use CLI and move various parts into their own functions for clarity / reuse
  • Update main/Kconfig.projbuild so that default SSID/password are '' (empty string) which means that the default behavior will now be to connect to whatever AP was previously connected / saved in WiFi NVS.
  • Enable c++ exceptions in sdkconfig

Motivation and Context

Closes #11

How has this been tested?

Build and run main on ESP32-TimerCam hardware, use CLI to configure it.

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

CleanShot 2025-06-22 at 22 38 41

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

@finger563 finger563 requested a review from Copilot June 23, 2025 03:53
@finger563 finger563 self-assigned this Jun 23, 2025
@finger563 finger563 added enhancement New feature or request cli command line interface wifi labels Jun 23, 2025
@github-actions
Copy link

✅Static analysis result - no issues found! ✅

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades to espp v1.0.10, restructures app_main to use a CLI-based WiFi STA menu for runtime configuration, and adjusts defaults to connect to saved WiFi credentials by default.

  • Update to esp-cpp/espp v1.0.10 and enable C++ exceptions
  • Refactor main.cpp into helper functions and integrate WifiStaMenu + CLI
  • Set default SSID/password to empty and adjust Kconfig to use saved WiFi NVS

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
sdkconfig.defaults Enable C++ exceptions (CONFIG_COMPILER_CXX_EXCEPTIONS=y)
main/main.cpp Refactor app_main into initialize_camera, start_rtsp_server, camera_task_fn; add CLI menu for runtime WiFi and camera interaction
main/Kconfig.projbuild Change ESP_WIFI_SSID/ESP_WIFI_PASSWORD defaults to empty
Comments suppressed due to low confidence (2)

main/main.cpp:105

  • [nitpick] The new CLI commands (memory, battery) are useful but currently untested. Adding unit or integration tests for WifiStaMenu and the CLI handlers would help ensure correct behavior and catch regressions.
  espp::WifiStaMenu sta_menu(wifi_sta);

main/main.cpp:31

  • [nitpick] Helper functions initialize_camera, start_rtsp_server, and camera_task_fn lack doc comments. Adding brief descriptions of their responsibilities and parameters will improve maintainability.
esp_err_t initialize_camera(void);

@finger563 finger563 merged commit f6bbffe into main Jun 23, 2025
2 checks passed
@finger563 finger563 deleted the feat/11-wifi-configuration branch June 23, 2025 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cli command line interface enhancement New feature or request wifi

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Installation instructions

2 participants