Closed
Conversation
Author
|
before this change: after: |
Author
|
the same crash can be seen in #75 |
r00t-
force-pushed
the
check_set_slave_result
branch
from
d755866 to
3ff31b0
Compare
libmodbus considers some slave addresses invalid. it will report an error, but mbpoll previously ignored this, leading to a crash with an assertion failure.
zknpr
added a commit
to zknpr/mbpoll
that referenced
this pull request
Feb 6, 2026
## Security Fixes - Fix memory leak: piStartRef was not freed in cleanup paths - Add NULL checks after all malloc/calloc calls to prevent crashes - Add compiler security flags: -fstack-protector-strong, -D_FORTIFY_SOURCE=2, -Wformat-security ## Code Modernization - Modernize CMakeLists.txt with proper Release/Debug build separation - Use target-based CMake properties instead of global definitions - Add -Wpedantic flag (with exception for 3rdparty getopt code) - Update copyright years to 2015-2025 - Update libmodbus minimum version to 3.1.7 - Translate all French comments to English ## Community PR Integration - Implement PR epsilonrt#87: Check modbus_set_slave() return value to prevent crashes with invalid slave addresses (credit: @r00t-) - Implement PR epsilonrt#90: Add -x option to print register addresses in hexadecimal format (credit: @ciakval) - Implement PR epsilonrt#99: Add -Q and -X options for libmodbus quirks (MAX_SLAVE and REPLY_TO_BROADCAST) (credit: @JesseRiemens) ## New Features - `-x` Print address (reference) in hexadecimal format - `-Q` Enable MAX_SLAVE quirk (accept slave id 0-255) - `-X` Enable REPLY_TO_BROADCAST quirk (send reply to broadcast) ## CI/CD - Add GitHub Actions workflow for automated builds on Linux, macOS, and Windows Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
8 tasks
Owner
|
fix by #100 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libmodbus considers some slave addresses invalid.
it will report an error, but mbpoll previously ignored this, leading to a crash with an assertion failure.