fix(locking): Replace object_id-based locks with thread-local storage #226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous implementation stored locks in a class variable indexed by Thread.current.object_id, which had three critical defects: 1. Object ID reuse: Ruby can reuse object IDs after garbage collection, allowing new threads to inadvertently access stale locks from dead threads 2. Race conditions: The shared @@locks class variable was not thread-safe, creating potential race conditions 3. Memory leaks: Dead thread entries were not automatically cleaned up This fix replaces the class variable with Ruby's built-in thread-local storage (Thread.current[:double_entry_locks]), which: - Ties data directly to the thread object, not its object ID - Provides isolated storage per thread - Automatically cleans up when threads terminate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The locking mechanism used a class variable (
@@locks) indexed byThread.current.object_idto track account locks. This implementation had three critical defects:Changes
@@locksclass variableThread.current[:double_entry_locks])locks,locks=, andremove_locksmethods to use thread-local variablesConsequences
This fix ensures proper thread isolation without API changes. Thread-local variables are automatically cleaned up when threads terminate, eliminating memory leaks. The implementation is now both safer and more idiomatic Ruby.