Skip to content

WRP-4076:Button: add mising @mixes tag for TooltipDecorator #735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
hoeunryuLG wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

WRP-4076:Button: add mising @mixes tag for TooltipDecorator #735

hoeunryuLG wants to merge 1 commit into from

Conversation

@hoeunryuLG
Copy link

@hoeunryuLG hoeunryuLG commented Mar 10, 2023 •
edited
Loading

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • Documentation was verified or is not changed
  • UI test was passed or is not needed
  • Screenshot test was verified or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

Currently, TooltipDecorator is missing from includes for ButtonDecorator description on enactjs.com.
ButtonDecorator is composed of TooltipDecorator, but @mixes tag for TooltipDecorator is missing in the documentation.

Resolution

Add @mixes tag for TooptipDecorator.

Additional Considerations

Links

WRP-4076
enactjs/sandstone#1419

Comments

Eanct-DCO-1.0-Signed-off-by: Hoeun Ryu hoeun.ryu@lge.com

@hoeunryuLG
WRP-4076:Button: add mising @mixes tag for TooltipDecorator
ebffa5e 
ButtonDecorator is composed with TooltipDecorator, but @mixes tag for
TooltipDecorator is missing in the documentation. Add @mixes tag for
TooptipDecorator.

Eanct-DCO-1.0-Signed-off-by: Hoeun Ryu <hoeun.ryu@lge.com>
@CLAassistant
Copy link

CLAassistant commented Mar 10, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@hoeunryuLG hoeunryuLG mentioned this pull request Mar 10, 2023
Merged
5 tasks
@codecov
Copy link

codecov bot commented Mar 10, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (f63d8b1) 83.87% compared to head (2032235) 83.87%.

❗ Current head 2032235 differs from pull request most recent head ebffa5e. Consider uploading reports for the commit ebffa5e to get more accurate results

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop     #735   +/-   ##
========================================
  Coverage    83.87%   83.87%           
========================================
  Files          120      120           
  Lines         4447     4447           
  Branches      1223     1223           
========================================
  Hits          3730     3730           
  Misses         564      564           
  Partials       153      153
Impacted Files Coverage Δ
Button/Button.js 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

juwonjeong
juwonjeong approved these changes Mar 14, 2023
View reviewed changes
Copy link
Contributor

@juwonjeong juwonjeong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juwonjeong juwonjeong juwonjeong approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hoeunryuLG @CLAassistant @juwonjeong