Generate Google modules#353
Merged
whatyouhide merged 7 commits intoelixir-protobuf:mainfrom Oct 28, 2024
Merged
Conversation
Nezteb
approved these changes
Nov 27, 2023
whatyouhide
requested changes
May 25, 2024
Collaborator
whatyouhide
left a comment
whatyouhide
left a comment
There was a problem hiding this comment.
Finally having some time to go through these! I left a blocking comment but other than that this looks really good. Thank you @btkostner 💟
Co-authored-by: Andrea Leopardi <an.leopardi@gmail.com>
whatyouhide
changed the title
Collaborator
|
Can you check the CI failure related to regenerating files? 🙃 |
Collaborator
|
@whatyouhide I can't see the CI failures from back then, but I merged main here and everything is green. Should we merge? |
v0idpwn
approved these changes
Oct 26, 2024
Collaborator
|
Thanks folks! 💟 |
esimonov
reviewed
Nov 1, 2024
|
|
||
| ### Google Protos | ||
|
|
||
| Since `:protobuf` version `0.13.0` we include all of the well known Google Protobuf modules. This conflicts with the deprecated `:google_protos` package. Please remove the `:google_protos` package from your dependencies and run `mix deps.unlock --unused`. |
There was a problem hiding this comment.
I don't think it's actually true 🤔 If I pull 0.13.0 now, it won't contain these new files. Perhaps you meant the next patch/minor version?
Collaborator
There was a problem hiding this comment.
That's right, fixed it on #381. Thank you for pointing out!
v0idpwn
added a commit
that referenced
this pull request
Nov 1, 2024
Fixes issue pointed out at #353
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes the well known Google protobuf modules to deprecate the
google_protospackage. From this comment: elixir-protobuf/google-protos#21 (comment).