Skip to content

Fix automatic legacy_cpu detection for polars rustler #1131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nabijaczleweli wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix automatic legacy_cpu detection for polars rustler #1131

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions lib/explorer/polars_backend/native.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,22 +8,27 @@ defmodule Explorer.PolarsBackend.Native do
# We want "debug" in dev and test because it's faster to compile.
mode = if Mix.env() in [:dev, :test], do: :debug, else: :release

use_legacy =
use_legacy = (
env = System.get_env("EXPLORER_USE_LEGACY_ARTIFACTS")

Application.compile_env(
:explorer,
:use_legacy_artifacts,
System.get_env("EXPLORER_USE_LEGACY_ARTIFACTS") in ["true", "1"]
(if is_nil(env), do: nil, else: env in ["true", "1"])
)
)

variants_for_linux = [
legacy_cpu: fn ->
# These are the same from the release workflow.
# See the meaning in: https://unix.stackexchange.com/a/43540
needed_caps = ~w[fxsr sse sse2 ssse3 sse4_1 sse4_2 popcnt avx fma]

use_legacy or
(is_nil(use_legacy) and
not Explorer.ComptimeUtils.cpu_with_all_caps?(needed_caps))
if is_nil(use_legacy) do
not Explorer.ComptimeUtils.cpu_with_all_caps?(needed_caps)
else
use_legacy
end
end
]

Expand Down