[CR] 10월 2, 3주차 #98
Open
[CR] 10월 2, 3주차 #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blcklamb
reviewed
Oct 13, 2022
Contributor
blcklamb
left a comment
blcklamb
left a comment
There was a problem hiding this comment.
채정 => 송희
문자열 폭발💣 수고하셨습니다!
| for i in range(len(string)): | ||
| tmp.append(string[i]) | ||
| if tmp[-1] == bomb_str[-1] and len(tmp) >= len(bomb_str): | ||
| if tmp[-len(bomb_str):] == bomb_str: |
Contributor
There was a problem hiding this comment.
조건문 처리할 때 처음에 최대한 조건을 줄여야지 시간이 적게 나올 것 같은데,
송희님께서 하신 부분이 가장 적게 나오네요!(536ms) 흥미로운 지점입니다.
if tmp[-1] == bomb_str[-1]:
if len(tmp) >= len(bomb_str) and tmp[-len(bomb_str):] == bomb_str:
=> 548ms
if tmp[-1] == bomb_str[-1]:
if len(tmp) >= len(bomb_str):
if tmp[-len(bomb_str):] == bomb_str:
=> 580ms
| if tmp: | ||
| print("".join(tmp)) | ||
| else: | ||
| print("FRULA") |
Contributor
There was a problem hiding this comment.
조건문 처리 외에 나머지는 저와 거의 동일합니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
문제 번호
리뷰어에게
Puyo Puyo랑 모음사전은 @blcklamb 님이,
문자열 폭발은 @Malza0408 님이 해주시면 됩니다...ㅎㅎ
제가 브랜치도 나눠놓고 이전 CR을 제 때 생성 안해서 이렇게 됐네요...
잘 부탁드립니다~!!