Optimizes calls to css(), width() and height() for performance reasons#43
Open
nos3 wants to merge 2 commits intoelevateweb:masterfrom
Open
Optimizes calls to css(), width() and height() for performance reasons#43nos3 wants to merge 2 commits intoelevateweb:masterfrom
nos3 wants to merge 2 commits intoelevateweb:masterfrom
Conversation
slackero
added a commit
to slackero/elevatezoom
that referenced
this pull request
Jan 23, 2015
elevateweb#40 Erase already created zoomContainer elevateweb#43 Optimizes calls to css(), width() and height() for performance reasons
|
@nsendetzky Hi there, FYI, I have re-created the elevatezoom into EZPlus, an up-to-date project at: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Profiling has shown that calls of the jquery css() method consumed very much time when moving the lens. This resulted in lags when moving the lens fast in Firefox and IE. By optimizing the css() calls (and also width() / height() methods) and the their parameters, the lags are now almost gone.