Added arguments in the callback with bind#27
Open
bartbroere wants to merge 10 commits intoekulyk:masterfrom
Open
Added arguments in the callback with bind#27bartbroere wants to merge 10 commits intoekulyk:masterfrom
bartbroere wants to merge 10 commits intoekulyk:masterfrom
Conversation
…however) This is useful for pusher messages that include variables in the name of the message (or the channel for that matter), instead of in the data. When setting the callback, some keyword arguments can be provided that should be supplied with each message. In my codebase this change prevented that I have to do one of the following: - have lots of functions with repeating code, - write wrapper functions, - define lots of functions with lambdas in for loops. In an ideal world this change would not be necessary, but in a lot of practical use cases, it is nice to have it. Furthermore, this change is nearly completely backwards compatible, unless an implementation uses the variables in the spawned instance directly.
Author
|
@ekulyk Would you consider merging these changes? Thanks in advance. |
bartbroere
changed the title
Author
|
If these changes are not merged, I will probably make my own version of PythonPusherClient, and upload it to Pypi, because a project I plan to release will be dependent on the changes made here. |
|
@ekulyk this is a very usful feature. Is it gonna be merged? |
This reverts commit c41a771.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is useful for pusher messages that include variables in the name of
the message (or the channel for that matter), instead of in the data.
When setting the callback, some keyword arguments can be provided that
should be supplied with each message. In my codebase this change
prevented that I have to do one of the following:
In an ideal world this change would not be necessary, but in a lot of
practical use cases, it is nice to have it.
Furthermore, this change is nearly completely backwards compatible,
unless an implementation uses the variables in the spawned instance
directly.