Add custom validation other solution #98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
oylenshpeegul
left a comment
oylenshpeegul
left a comment
There was a problem hiding this comment.
This looks great!
I was confused for a bit why there wasn't a change to codelist_options.rs to remove the custom regex, but of course that was just added in #97 and this bypasses that entirely.
I like how LazyLock being in the standard library means we do not have to add anything to [dev-dependencies] or whatever.
CarolineMorton
requested changes
Jun 25, 2025
Collaborator
CarolineMorton
left a comment
CarolineMorton
left a comment
There was a problem hiding this comment.
A couple of comments about tests. Well done Emma this is much simpler and easier to understand. Let's get these changes checked in and close the other PR.
CarolineMorton
approved these changes
Jun 26, 2025
Collaborator
CarolineMorton
left a comment
CarolineMorton
left a comment
There was a problem hiding this comment.
Hey Emma, this looks great, thanks. Let;s get this merged in.
Comment on lines
+305
to
+307
| codelist.add_entry("A11", "Valid test code") | ||
| codelist.validate_codes("^A") | ||
| codelist.add_entry("B112", "Invalid test code") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative method, a lot simpler.
Closes #93