Skip to content

新增 grpc ssl 安全配置#14

Open
xdxiaodong wants to merge 2 commits intoeggjs:masterfrom
xdxiaodong:master
Open

新增 grpc ssl 安全配置#14
xdxiaodong wants to merge 2 commits intoeggjs:masterfrom
xdxiaodong:master

Conversation

@xdxiaodong
Copy link

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

新增 grpc client ssl 安全配置

@atian25 atian25 requested a review from JasinYip December 9, 2019 01:49
@JasinYip
Copy link
Member

JasinYip commented Dec 9, 2019

Thanks for your contributing. 🎉

Please make sure that the code is checked through the checklist and pass the CI testing.

We might need some tests to test this new feature.

Otherwise, I notice the package name (which in package.json) has been changed, we should keep the name as before as send it to npm.

It might also includes a breaking change which is unnecessary - The configuration of this plugin didn't support multiple entries so the configurations could set the first client configurations directly without clients layer. If we want to make it supports the multiple entries we might need to keep supporting directly with one client configuration. We can check if the clients field is exists at the first time.

@JasinYip
Copy link
Member

JasinYip commented Dec 9, 2019

reference to eggjs/egg#4077

@xdxiaodong
Copy link
Author

Thanks for your contributing. 🎉

Please make sure that the code is checked through the checklist and pass the CI testing.

We might need some tests to test this new feature.

Otherwise, I notice the package name (which in package.json) has been changed, we should keep the name as before as send it to npm.

It might also includes a breaking change which is unnecessary - The configuration of this plugin didn't support multiple entries so the configurations could set the first client configurations directly without clients layer. If we want to make it supports the multiple entries we might need to keep supporting directly with one client configuration. We can check if the clients field is exists at the first time.

https://github.com/xdxiaodong/egg-grpc-x

Copy link
Member

@JasinYip JasinYip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some issues need to be fixed written above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants