feat: addition of work as an entity type #143
Conversation
HelenaSabel
force-pushed
the
feat/work-register
branch
from
e8178f4 to
28593b4
Compare
|
@HelenaSabel can we have a session on this when we are both available to check it's not in conflict with the bibliography support I added a while ago to the registers profile? Sorry I didn't have time to take care of it earlier, but that was the reason |
tuurma
left a comment
tuurma
left a comment
There was a problem hiding this comment.
I would approve PR as is, made two small suggestions to be addressed, possibly at a later date, at @HelenaSabel's discretion.
| case 'term' | ||
| return collection($config:register-root)/id($config?id)//tei:category[starts-with(@xml:id, $config?prefix)]/substring-after(@xml:id, $config?prefix) | ||
| case 'work' | ||
| return collection($config:register-root)/id($config?id)//(tei:bibl|tei:biblStruct)[starts-with(@xml:id, $config?prefix)]/substring-after(@xml:id, $config?prefix) |
There was a problem hiding this comment.
@HelenaSabel why biblStruct here if it's not supported in the work-template?
| <catDesc>{$data?name}</catDesc> | ||
| </category> | ||
| case "work" return | ||
| <bibl xmlns="http://www.tei-c.org/ns/1.0" xml:id="{$id}"> |
There was a problem hiding this comment.
how about adding @type="work" which would give us the option to later filter cited works and project bibliography if needed?
There was a problem hiding this comment.
just a reminder that GND works include recordings, art works, performances, etc. So I'm not sure if we would want to always turn these into bibl in TEI
There was a problem hiding this comment.
@duncdrum that's at a user discretion, they can always create additional registers if they want to record these (or mix and mingle, not our job to stop them)
rp-gnd-118536109(in which onlyrp-is the prefix) and then we want to generate custom entries with an ID likerp-000001