-
-
Notifications
You must be signed in to change notification settings - Fork 7
feat(editor): integrate pb-facsimile into the editor page #131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
0b1fee8 to
381e49b
Compare
381e49b to
ee6ddbd
Compare
|
@wolfgangmm this is rebased again. My main uncertainty now is how the interfacing with pb-facsimile works for clicking on the links. It works, but it makes some assumptions on the format of the event: https://github.com/eeditiones/jinks/pull/131/files#diff-9bdf927f0f5bf635b2e7a8def42a8426d93831281b53fcc9d8248d65011dc843R121 Besides that, I think the rest is quite OK. It reads from the XML roughly how pb-facsimile does it, with the base url configurable. |
ee6ddbd to
c593c00
Compare
wolfgangmm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My main problem with this is that it assumes a very particular use of <surface> together with a @start attribute, but as always, TEI allows more than one way of encoding. It's not wrong to take a best practice approach here, but we would need to document it and check with @tuurma and @HelenaSabel what we would recommend.
Could you show us an example of how your encoding of <pb> and <surface> looks like?
And use click events on the tei:pb elements to sync them
To scan it for facsimiles
1999dde to
1895b82
Compare
|
Thanks! These assumptions are now documented in /profiles/jinntap/doc/README.md, along with an example file (that I've verified to be working) |
1895b82 to
9ef82d4
Compare
And use click events on the tei:pb elements to sync them.
@wolfgangmm I iterated a bit on this PR. What do you reckon?