Skip to content

Conversation

@DrRataplan
Copy link
Contributor

@DrRataplan DrRataplan commented Sep 4, 2025

And use click events on the tei:pb elements to sync them.

@wolfgangmm I iterated a bit on this PR. What do you reckon?

@DrRataplan DrRataplan force-pushed the feat/pb-facsimile-jinn-tap branch from 0b1fee8 to 381e49b Compare September 10, 2025 11:30
@DrRataplan DrRataplan force-pushed the feat/pb-facsimile-jinn-tap branch from 381e49b to ee6ddbd Compare October 7, 2025 13:25
@DrRataplan
Copy link
Contributor Author

@wolfgangmm this is rebased again.

My main uncertainty now is how the interfacing with pb-facsimile works for clicking on the links. It works, but it makes some assumptions on the format of the event: https://github.com/eeditiones/jinks/pull/131/files#diff-9bdf927f0f5bf635b2e7a8def42a8426d93831281b53fcc9d8248d65011dc843R121

Besides that, I think the rest is quite OK. It reads from the XML roughly how pb-facsimile does it, with the base url configurable.

@duncdrum duncdrum added the release Jinks 1.0.0 label Nov 26, 2025
@DrRataplan DrRataplan force-pushed the feat/pb-facsimile-jinn-tap branch from ee6ddbd to c593c00 Compare December 3, 2025 13:13
Copy link
Member

@wolfgangmm wolfgangmm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My main problem with this is that it assumes a very particular use of <surface> together with a @start attribute, but as always, TEI allows more than one way of encoding. It's not wrong to take a best practice approach here, but we would need to document it and check with @tuurma and @HelenaSabel what we would recommend.

Could you show us an example of how your encoding of <pb> and <surface> looks like?

@DrRataplan DrRataplan force-pushed the feat/pb-facsimile-jinn-tap branch 4 times, most recently from 1999dde to 1895b82 Compare December 9, 2025 15:22
@DrRataplan
Copy link
Contributor Author

DrRataplan commented Dec 9, 2025

Thanks! These assumptions are now documented in /profiles/jinntap/doc/README.md, along with an example file (that I've verified to be working)

@DrRataplan DrRataplan force-pushed the feat/pb-facsimile-jinn-tap branch from 1895b82 to 9ef82d4 Compare December 9, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release Jinks 1.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants