feat(adr):Add an option to use Caddy instead of Nginx#1360
Open
herrdragon wants to merge 2 commits intoedgexfoundry:mainfrom
Open
feat(adr):Add an option to use Caddy instead of Nginx#1360herrdragon wants to merge 2 commits intoedgexfoundry:mainfrom
herrdragon wants to merge 2 commits intoedgexfoundry:mainfrom
Conversation
Signed-off-by: Miguel Herrnsdorf <lherrnsd@bmc.com>
herrdragon
changed the title
cloudxxx8
requested changes
Jul 16, 2024
Explain more about the flag and add pros and cons
cloudxxx8
requested changes
Jul 30, 2024
Member
cloudxxx8
left a comment
cloudxxx8
left a comment
There was a problem hiding this comment.
for the ADR, we expect more details like the one Bryon wrote for nginx
https://docs.edgexfoundry.org/3.1/design/adr/security/0028-authentication/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Miguel Herrnsdorf miguel.herrnsdorf@gmail.com