refactor(dataset-store): extract amp-providers-registry crate
#1564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shiyasmohd
changed the title
amp-providers-registry crate
LNSD
reviewed
Jan 16, 2026
| use std::path::PathBuf; | ||
|
|
||
| use amp_dataset_store::DatasetKind; | ||
| use amp_providers_registry::dataset_kind::DatasetKind; |
Contributor
There was a problem hiding this comment.
From my POV, it makes no sense to depend on the provider registry crate to use the dataset kind type. We should find a way to encode the different kinds at the typesystem level without an enum. Maybe via a trait. Idk.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
amp-providers-registrycrate fromamp-dataset-storeadmin-apito useDatasetsRegistrydirectly for registry operationsCloses #1558