forked from salesforce/bazel-eclipse
-
Notifications
You must be signed in to change notification settings - Fork 3
Optimize project structure for cases without Java files #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
runchen0919
wants to merge
2
commits into
eclipseguru:main
Choose a base branch
from
runchen0919:issue-39
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
345 changes: 342 additions & 3 deletions
345
...e.core/src/com/salesforce/bazel/eclipse/core/model/discovery/projects/JavaSourceInfo.java
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| # bazelmod is enabled by default in bazel 7, but we are not ready yet | ||
| common --noenable_bzlmod |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| ############################################################################### | ||
| # Bazel now uses Bzlmod by default to manage external dependencies. | ||
| # Please consider migrating your external dependencies from WORKSPACE to MODULE.bazel. | ||
| # | ||
| # For more details, please check https://github.com/bazelbuild/bazel/issues/18958 | ||
| ############################################################################### |
13 changes: 13 additions & 0 deletions
13
bundles/testdata/workspaces/001/module4/java/com/project/server/examples/BUILD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||
|---|---|---|---|---|
| @@ -0,0 +1,13 @@ | ||||
| load("@rules_java//java:defs.bzl", "java_library") | ||||
|
|
||||
| java_library( | ||||
| name = "async_commit_example", | ||||
| srcs = glob([ | ||||
| "*.java", | ||||
| "async_commit_example/*.java", | ||||
| "async_commit_example/annotations/*.java", | ||||
| ]), | ||||
| deps = [ | ||||
| ], | ||||
| ) | ||||
|
|
||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think the next step is to add some assertions to Line 42 in 9542833
|
||||
9 changes: 9 additions & 0 deletions
9
...aces/001/module4/java/com/project/server/examples/async_commit_example/ExampleDaemon.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| package com.project.server.examples.async_commit_example; | ||
|
|
||
| import com.project.server.examples.async_commit_example.annotations.RandomMessageGenSub0; | ||
| import com.project.server.examples.async_commit_example.annotations.RandomMessageGenSub1; | ||
|
|
||
|
|
||
| public class ExampleDaemon { | ||
|
|
||
| } |
13 changes: 13 additions & 0 deletions
13
...va/com/project/server/examples/async_commit_example/annotations/RandomMessageGenSub0.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| package com.project.server.examples.async_commit_example.annotations; | ||
|
|
||
| import java.lang.annotation.Retention; | ||
| import java.lang.annotation.RetentionPolicy; | ||
| import java.lang.annotation.Target; | ||
|
|
||
| import static java.lang.annotation.ElementType.METHOD; | ||
| import static java.lang.annotation.ElementType.PARAMETER; | ||
|
|
||
| @Retention(RetentionPolicy.RUNTIME) | ||
| @Target({METHOD, PARAMETER}) | ||
| public @interface RandomMessageGenSub0 { | ||
| } |
13 changes: 13 additions & 0 deletions
13
...va/com/project/server/examples/async_commit_example/annotations/RandomMessageGenSub1.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| package com.project.server.examples.async_commit_example.annotations; | ||
|
|
||
| import java.lang.annotation.Retention; | ||
| import java.lang.annotation.RetentionPolicy; | ||
| import java.lang.annotation.Target; | ||
|
|
||
| import static java.lang.annotation.ElementType.METHOD; | ||
| import static java.lang.annotation.ElementType.PARAMETER; | ||
|
|
||
| @Retention(RetentionPolicy.RUNTIME) | ||
| @Target({METHOD, PARAMETER}) | ||
| public @interface RandomMessageGenSub1 { | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.