Draft
Conversation
- library targets uses on the frontend - while test targets provide the concrete backends. For unit tests a lightweight console recorder with console logging backend is sufficient. - for a binary target a log target that includes all backends can be used.
License Check Results🚀 The license check job ran with the Bazel command: bazel run //:license-checkStatus: Click to expand output |
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mw/log frontend is part of the https://github.com/eclipse-score/baselibs repo
mw/log recorders and respective concrete backends are part of https://github.com/eclipse-score/logging repo
That said, the mw/log:log target is no longer supported in the baselibs and requires to be fixed.
See: https://github.com/eclipse-score/baselibs/blob/381dd9a9c9c516d87b0840f61618ba9e668dabd5/score/mw/log/BUILD#L25
In order to integrate datarouter to the reference integration platform, the deps need to be fixed as a prerequisite.
The CI build jobs will be fixed after eclipse-score/communication#143 is resolved.